Fix animated icon glitches #4722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samholmes
approved these changes
Jan 17, 2024
Comment on lines
+54
to
+61
| return ( | ||
| <Animated.Text accessible={accessible} style={style}> | ||
| {String.fromCodePoint(glyphMap[name])} | ||
| </Animated.Text> | ||
| ) |
There was a problem hiding this comment.
We should document this approach with comments. Something to mention is the importance of using a single Animated.Text component for animated icons to avoid the buggy behavior in reanimated. Also, mention the limitation that switching between animated icons should be avoided completely in favor of parameterizing the icon name prop instead; this may limit our ability to switch between icons in different typesets.
Swapping the eye icon was leading to color glitches, due to some bug deep within react-native-reanimated. The solution involves rendering a single `Animated.Text` component, and simply changing the text content inside. This avoids re-wiring the Reanimated dependency graph, which is what seems to be causing the problem. We achieve this with *almost* the same icon API as before by adding an `off` property to the eye icon, to switch between the two variants. We also refactor the animated icon implementation to use a raw text element, instead of the react-native-vector-icon wrapper component.
swansontec
force-pushed
the
william/fix-pinkeye
branch
from
2462984
to
d1e1e8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swapping the eye icon was leading to color glitches, due to some bug deep within react-native-reanimated.
The solution involves rendering a single
Animated.Textcomponent, and simply changing the text content inside. This avoids re-wiring the Reanimated dependency graph, which is what seems to be causing the problem.We achieve this with almost the same icon API as before by adding an
offproperty to the eye icon, to switch between the two variants. We also refactor the animated icon implementation to use a raw text element, instead of the react-native-vector-icon wrapper component.CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: